Skip to content

Initial porting of existing pages - #5

Merged
JeremyMcCormick merged 1 commit into
mainfrom
content/inital_pages
Mar 20, 2024
Merged

JeremyMcCormick merged 1 commit into
mainfrom
content/inital_pages

Conversation

@KlaasYK

@KlaasYK KlaasYK commented Feb 9, 2024 •

Copy link
Copy Markdown
Contributor

Existing pages can be put under the content/pages/<category> directory.
Linking on the main page is done in the content/_index.html using a {{<ref "pages/about/what_is_vo">}} instead of a real URI.

@JeremyMcCormick

JeremyMcCormick commented Feb 26, 2024 •

Copy link
Copy Markdown
Collaborator

Is the date: field in the markdown files filled in manually?

Possible solution here:

https://bookdown.org/yihui/rmarkdown-cookbook/update-date.html

If so, is this something that should be automated so it doesn't need to be done by hand every time someone modifies a page?

@JeremyMcCormick

JeremyMcCormick commented Feb 26, 2024 •

Copy link
Copy Markdown
Collaborator

This looks good to me, @KlaasYK.

I'll approve if you actually want to merge it, unless this was supposed to be left up as an example.

@JeremyMcCormick
JeremyMcCormick self-requested a review February 26, 2024 21:48

@molinaro-m molinaro-m left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the "gettng started" page, I'd prefer seeing a _one use case" limited translation rather then a lorem ipsum, just to see images and external links in action.
Otherwise I'm fine, also because we are testing and building.

I leave to @JeremyMcCormick the formal approval, based on his question about the issue purpose.

@KlaasYK

KlaasYK commented Mar 5, 2024

Copy link
Copy Markdown
Contributor Author

@JeremyMcCormick the date is not updated automatically. I think there are options for that in Hugo based on the git date: https://gohugo.io/methods/page/gitinfo/

@molinaro-m I will see if I can replace the iorem ipsum with something more "real" and also include links/images :)

@JeremyMcCormick

Copy link
Copy Markdown
Collaborator

@JeremyMcCormick the date is not updated automatically. I think there are options for that in Hugo based on the git date: https://gohugo.io/methods/page/gitinfo/

Thanks, this looks like exactly what we want - I'll try to play with it locally and when I have a chance.

@molinaro-m molinaro-m left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this was waiting further approval.
At least as a test for the action, it could be useful to try it.

@JeremyMcCormick JeremyMcCormick left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good example of porting a page. I will approve so it can be put into the test site.

@JeremyMcCormick
JeremyMcCormick merged commit 533ad39 into main Mar 20, 2024
@JeremyMcCormick
JeremyMcCormick deleted the content/inital_pages branch May 19, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants